bringing units to the colorscale #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xchourio
approved these changes
Jan 27, 2025
aaron-kaplan
reviewed
Feb 5, 2025
aaron-kaplan
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This made me have the colorscale be vertical to accommodate sometimes long units. It would make sense that colorbar could have a label or title in which to put the units ones, but it doesn't have that. The way to tailor further with having maybe the units on only one tick would be to create the entire ticking manually and feed it to colorbar. But that sounds tedious, at least for now.
Also made me revisit a bit the map_attributed factored out function since now it needs data all the time to read units. Or at least that workflow seemed to make more sense to me.